-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create markdown docs from docstring in py files #2181
Create markdown docs from docstring in py files #2181
Conversation
Found a problem we need to address, see NiklasRosenstein/pydoc-markdown#308 |
Enforcing the docstring style to sphinx did help for the code sample formatting problem. |
Fixes also #1771 |
Could be merged, any comments? |
…ture3/pydoc-markdown
|
||
Callback handler instance for service_is_running_callbacks events. | ||
|
||
See :class:`ServiceIsRunningCallbacks` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should :class:
be rendered? Or be a link?
compare change in rfid/reader/init.py #55
https://github.com/s-martin/RPi-Jukebox-RFID/blob/63ecd190ea7303a7c643b79615f07b34a2f81a4e/src/jukebox/components/rfid/reader/__init__.py#L55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all occurrences of :class: are currently converted to # syntax
src/jukebox/components/rfid/hardware/template_new_reader/template_new_reader.py
Show resolved
Hide resolved
Do we need an action that checks for changed but uncommited docs? As the precommit hook must be activated manually and could be forgotten (like flake8). The action could run "./run_docgeneration.sh" and fail the build if there a outgoing changes? |
I would suggest the following:
My question would be, should I extend the Python action or add another one? What do you think? Discussion about action OR hook was already in #2159 |
Extending the current action would be fine for me. Would you also add |
I would add flake8-docstrings in a separate PR. Right now there are many warnings, which would fix in this separate PR. |
Added a check in the action. Needs more testing, though. |
The action does not work as expected, therefore I will add the integration into the Python action in a separate PR later. Otherwise it could be merged from my point of view. |
Pro/con evaluation of different tools can be found here s-martin#31
Replaces #2159