Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create markdown docs from docstring in py files #2181

Merged
merged 43 commits into from
Jan 16, 2024

Conversation

s-martin
Copy link
Collaborator

@s-martin s-martin commented Dec 26, 2023

Pro/con evaluation of different tools can be found here s-martin#31

Replaces #2159

@s-martin
Copy link
Collaborator Author

Found a problem we need to address, see NiklasRosenstein/pydoc-markdown#308

@s-martin
Copy link
Collaborator Author

s-martin commented Dec 26, 2023

Found a problem we need to address, see NiklasRosenstein/pydoc-markdown#308

Enforcing the docstring style to sphinx did help for the code sample formatting problem.

@s-martin s-martin linked an issue Dec 28, 2023 that may be closed by this pull request
@s-martin
Copy link
Collaborator Author

Fixes also #1771

@s-martin
Copy link
Collaborator Author

s-martin commented Jan 2, 2024

Could be merged, any comments?

documentation/developers/docstring/README.md Outdated Show resolved Hide resolved
documentation/developers/docstring/README.md Show resolved Hide resolved
documentation/developers/docstring/README.md Show resolved Hide resolved

Callback handler instance for service_is_running_callbacks events.

See :class:`ServiceIsRunningCallbacks`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all occurrences of :class: are currently converted to # syntax

documentation/developers/docstring/README.md Show resolved Hide resolved
@AlvinSchiller
Copy link
Collaborator

Do we need an action that checks for changed but uncommited docs? As the precommit hook must be activated manually and could be forgotten (like flake8).

The action could run "./run_docgeneration.sh" and fail the build if there a outgoing changes?

@s-martin
Copy link
Collaborator Author

s-martin commented Jan 4, 2024

Do we need an action that checks for changed but uncommited docs? As the precommit hook must be activated manually and could be forgotten (like flake8).

The action could run "./run_docgeneration.sh" and fail the build if there a outgoing changes?

I would suggest the following:

  • keep the current pre commit hook, so devs can already check their changes
  • in addition add a GitHub Action in case someone didn't activate pre commit hooks (similar to flake8 behavior)

My question would be, should I extend the Python action or add another one? What do you think?

Discussion about action OR hook was already in #2159

@AlvinSchiller
Copy link
Collaborator

Extending the current action would be fine for me.

Would you also add flake8-docstrings like mentioned in #2159?

@s-martin
Copy link
Collaborator Author

s-martin commented Jan 5, 2024

I would add flake8-docstrings in a separate PR. Right now there are many warnings, which would fix in this separate PR.

@s-martin
Copy link
Collaborator Author

s-martin commented Jan 5, 2024

Added a check in the action. Needs more testing, though.

@s-martin
Copy link
Collaborator Author

The action does not work as expected, therefore I will add the integration into the Python action in a separate PR later.

Otherwise it could be merged from my point of view.

@pabera pabera added this to the v3.5 milestone Jan 16, 2024
@s-martin s-martin merged commit 4f015dd into MiczFlor:future3/develop Jan 16, 2024
21 checks passed
@s-martin s-martin deleted the future3/pydoc-markdown branch January 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation future3 Relates to future3 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 | [future3] Documentation of Plugin System
3 participants